VSOH - Advanced Crafting Bot v1.1 : VGExtreme Programs

[beergeek]

Curious about making the bot stop doing the quality actions if below a certain # of AP's. I've turned off the remedies when below a certain amount but looking through the code for tool, util use and such not sure where I could put in the Crafting_ActionPointsLeft check...

Any help would be appriciated

It would actually have to be put in each section (tool1, tool2, etc.) for every action that has a quality boost.

Normally, it just checks to see if you have enough ap to perform the action, not if you are low. There is one exception: station 2 action 2. I have a formula in there that makes a conservative determination whether or not there's enough ap to finish before it will perform a quality action, but it will only do quality on that action family if util1 and both tool steps are complete. (this is in tier 5 crafting). You can use it as an example if you wish to make changes.

[drel]

The other issue i'm seeing is that if it tries to do a remedy, and it clicks the second one, but i'm out of the component, when it tries to click on the first one it moves the mouse too far to the left. Any ideas?

[lazzer]

The other issue i'm seeing is that if it tries to do a remedy, and it clicks the second one, but i'm out of the component, when it tries to click on the first one it moves the mouse too far to the left. Any ideas?

To my understanding the bot uses the coordinate from the center of the 'C' in cancel to click on the remedies. Check said coordinate and make sure the tip of the mouse pointer is in the middle of the 'C'.

[drel]

It is, it works fine when it attempts to click the first remedy.. its only when it tries to click the second, fails, then tries to click the first that it moves to far to the left.

[mythicskunk]

Well I'm getting 0 values for the ExtraOffsets you wrote beergeek. Even though i noticed it last night in the debug log, i downloaded and ran the vartest.vbs you put together and got the same return. All vars are returning good data except

'Crafting_BaseFinUtilSkill() 'Reads the characters base (unbuffed/unmodded) finishing utility skill
'Crafting_BaseFinStatSkill() 'Reads the characters base (unbuffed/unmodded) finishing station skill
'Crafting_BaseFinToolSkill() 'Reads the characters base (unbuffed/unmodded) finishing tool skill
'Crafting_BaseRefUtilSkill() 'Reads the characters base (unbuffed/unmodded) refining utility skill
'Crafting_BaseRefStatSkill() 'Reads the characters base (unbuffed/unmodded) refining station skill
'Crafting_BaseRefToolSkill() 'Reads the characters base (unbuffed/unmodded) refining tool skill
'Crafting_Level()

Is it possible the mem locations have changed in a recent patch?

[beergeek]

Well I'm getting 0 values for the ExtraOffsets you wrote beergeek.

Yes, I was talking to wyvernx about this and apparently the base address for VG can vary machine to machine and I'm calling the addresses directly. Once I get it figured out, I'll post an update so it works for everyone.

To my understanding the bot uses the coordinate from the center of the 'C' in cancel to click on the remedies. Check said coordinate and make sure the tip of the mouse pointer is in the middle of the 'C'.

Yes, I based it from the center of the C but it still needs tweaking. To drel: are you using the default crafting ui or a custom ui that uses the default craft windows?

[beergeek]

All those who are having problems with the script reading your crafting skills, try this:

Load the attached file into your exhume/includes directory, overwriting the existing file vgextraoffsets.vbs

It should now be reading the initial ponter at an offset from the base address of the dll rather than the absolute addresses I had in before.

Let me know if this works...

[officers]

Beergeek,

I loaded the new VGExtraOffsets.vbs and it now recognizes my skills perfectly and the script runs well.

I will let you know if I experience any problems with the new VGExtraOffsets.vbs.

[beergeek]

Beergeek,

I loaded the new VGExtraOffsets.vbs and it now recognizes my skills perfectly and the script runs well.

I will let you know if I experience any problems with the new VGExtraOffsets.vbs.

Sweet, I think I've got that nailed, then.

(addl. thanks to wyvernx)

[mythicskunk]

All offsets are returning good data. Thanks guys.

[drel]

To drel: are you using the default crafting ui or a custom ui that uses the default craft windows?

Default crafting ui...

Awesome about the skill fix

[ve_necro]

I would just like to add something for those of you who said you had issues with the script not hitting complications right as the X and Y seemed off. Like a n00b I was having the same issues even with the new VGExtraOffsets.vbs... If you still have the issue try doing something I totally forgot to do myself till it hit me last night mid raid.

Strip off naked, take off all buffs etc and then hard code in your stats, once it had my true base stats it crafted like a dream and hits every complication first time, the only issue I still have is with the one action but not being at home I dont have the data to hand right now, I will get it for you and post beergeek, I click 1 and it continues np so not really a hardship for me.

[ve_necro]

OK managed to actually get it running on my laptop here at work so here is the info on the action I meantioned:

Stage 2 Fashioning
Skill - Sculpting Tools
Attribute - Finesse
Progress - Moderate
Tool - Engraver
Cost - 75

It is located as action 1

I am a minerologist (thought you would need that hehe)

[beergeek]

OK managed to actually get it running on my laptop here at work so here is the info on the action I meantioned:

Stage 2 Fashioning
Skill - Sculpting Tools
Attribute - Finesse
Progress - Moderate
Tool - Engraver
Cost - 75

It is located as action 1

I am a minerologist (thought you would need that hehe)

In the data, I have the action "Fashion" as action 1 of the tool1 action family "Fashion"

FYI, sometimes the game will change the order of actions within a particular action family without any apparent logic. This is the reason I have matrices set up with the action names and the expected orders.

If something is clicking incorrectly (which I haven't noticed.. I've spent many levels on an artificer with this bot without problem), then start a clean log, turn on debug logging and PM me the logfile.

Strip off naked, take off all buffs etc and then hard code in your stats, once it had my true base stats it crafted like a dream and hits every complication first time

If you've patched the vgextraoffsets.vbs file, this shouldn't be necessary. Download that file again and overwrite the existing file. It should be located in the exhume/Includes directory, NOT exhume/ACBIncludes. This will be the same subdirectory that contains vgservice.vbs. vgextraoffsets.vbs is the only one in the crafting bot that goes in here.

If after doing this it still doesn't work, I'll need your log AND the offsets file from your exhume/includes directory.

[ve_necro]

I patched the file again for what I thought to be a second time and it works perfect now, guess I must have imagined it the first time.