VSOH - Advanced Crafting Bot v1.1 : VGExtreme Programs

[beergeek]

Hiya, where in the script does it list the location for the Complication buttons. Right now when it clicks it misses the second complication. Thanks.

officers is right in that the comp remedy locations are based on the crafting cancel button. Two reasons for this: 1- fewer mouseclicks to configure and 2- the location of the comp remedies changes depending on how many remedies are available.

The script was written for the default crafting UI (DroxUI and other compilations that use the default crafting windows also work). Also make sure your UI scale is 100% (there used to be a slider for this in beta, not sure if it's still there)

If none of that works, tell me if it's clicking too far to the left or right, as well as whether comp remedies are being clicked correctly (and if not, whether it's high, low, left or right) and I'll make some suggestions to tweak your script.

[officers]

if its slightly off, and almost missing comp 1, then you can try adjusting where you put your cancel button location to snag em.

[railshot]

What does error

'Error:Line 839, Char:4::Input past end of file


Line 839 is:

strSearchString = objFile.ReadAll


Thanks.

That happened to me before. Here's how to fix it. Look at the line where the error is, there should be a filename (it's some sort of a log file). This file is probably missing, so create one in notepad with exactrly the same name. It can be empty or you can put a few chars in there (it gets wiped anyway)

[railshot]

beergeek, my problem when it misses a coplication is back with a vengeance. Now it does it all the time. I rechecked the coords of the cancel button--does not help. The funny thing is, if I stop the script and restart, it takes care of the complication just fine until the next complication occurs and then it's off (and not slightly) again.

[officers]

some useful info for him railshot:
1) What is your UI or have you implanted a different UI into another for crafting specifically?

2) Where does it attempt to click when a complication arises? An idea for this would be running it on a WO with globalhook running to get the coordinates it clicks in, and supply your cancel button coordinates from the acbuserdata.vbs file.

[beergeek]

beergeek, my problem when it misses a coplication is back with a vengeance. Now it does it all the time. I rechecked the coords of the cancel button--does not help. The funny thing is, if I stop the script and restart, it takes care of the complication just fine until the next complication occurs and then it's off (and not slightly) again.

It never went away in the current release version. I have a fix for it in the version I'm running, but can't release that right now as it is in the middle of having a significant feature coded in.

In the meantime, try patching this procedure in acbinclude.vbs, overwriting the old. It is near the bottom of the file. Make sure you backup the old procedure first, in case I made some incompatible change I forgot about...

Code: Register to unlock hidden link

sub performCompRemedy()
                                    if debugState then debugLog "sub performCompRemedy, skipRemedy = " & skipRemedy end if
    if Not skipRemedy then    
        action = convInt(Left(activeComps(numActiveComps,1),1))
                                    if debugState then debugLog "action list: " & activeComps(numActiveComps,1) & "  desired remedy action: " & action   end if
        if activeComps(numActiveComps,2) >= 0 then
            actionInfo = compData(activeComps(numActiveComps,2),action + 1)
                                    if debugState then debugLog "action info: " & actionInfo  end if
            actionType = Left(actionInfo,1)
                                    if debugState then debugLog "action type: " & actionType   end if
            if actionType = "2" then
                idChangeToolBag(Right(actionInfo,(Len(actionInfo)-1)))
            end if
        end if
        For i = 1 to numActiveComps 
            Mouse.LMouseClick (CC_X+(50*i)+40), (CC_Y-30), 1, 1
        Next
                                    if debugState then debugLog "Click comp: " & (CC_X+(50*numActiveComps)+40) & ", " & (CC_Y-30)   end if
        select case activeComps(numActiveComps,3)       'number of comp remedies
            case 1
                Mouse.LMouseClick (CC_X+140), (CC_Y+60), 1, 1
                                    if debugState then debugLog "Click remedy1: " & (CC_X+140) & ", " & (CC_Y+60)   end if
            case 2
                Mouse.LMouseClick (CC_X+(action*50)+65), (CC_Y+60), 1, 1
                                    if debugState then debugLog "Click remedy2: " & (CC_X+(action*50)+65) & ", " & (CC_Y+60)   end if
            case 3
                Mouse.LMouseClick (CC_X+(action*50)+40), (CC_Y+60), 1, 1
                                    if debugState then debugLog "Click remedy3: " & (CC_X+(action*50)+40) & ", " & (CC_Y+60)   end if
            case 4
                Mouse.LMouseClick (CC_X+(action*50)+15), (CC_Y+60), 1, 1
                                    if debugState then debugLog "Click remedy4: " & (CC_X+(action*50)+15) & ", " & (CC_Y+60)   end if
        end select
        if debugState then debugLog "case for click (number remedies avail): " & activeComps(numActiveComps,3) end if
        sleep 2500
    end if
end sub

[officers]

Thanks Beergeek. I have patched the file and will try it out.

[railshot]

It never went away in the current release version. I have a fix for it in the version I'm running, but can't release that right now as it is in the middle of having a significant feature coded in.

What i meant, was that before this happened rarely, but after the last VSOH update it was occuring with every complication.
But no matter the patch worked great and everything is smooth as silk.
Thank you very much!

[beergeek]

you're welcome.

On an unrelated topic, I've found that having the mouseclick location for the crafting cancel button in the center of the first C in Cancel best centers the mouseclicks for the comp remedies.

[officers]

Hi Beergeek,

I am still getting stalls when some complication arise.

For instance, it's hanging on Bad Seam - Emergency Repairs. ER is the only comp up at this time and has 4 possible actions.

Minor repair, Fuse Damage, Access Damage, and Reinforce Stitching

When it hangs it looks like it is trying to click on an action that would be on the left of the first action that is actually there. It isn't missing be a little bit, it is missing by half of action block. In other words if the phantom action to the left were actually there it would be clicking in the middle of it.

If I start and stop the script it seems to fix itself.

I can PM you a screenshot if you would like.

[beergeek]

Hi Beergeek,

I am still getting stalls when some complication arise.

For instance, it's hanging on Bad Seam - Emergency Repairs. ER is the only comp up at this time and has 4 possible actions.

Minor repair, Fuse Damage, Access Damage, and Reinforce Stitching

When it hangs it looks like it is trying to click on an action that would be on the left of the first action that is actually there. It isn't missing be a little bit, it is missing by half of action block. In other words if the phantom action to the left were actually there it would be clicking in the middle of it.

If I start and stop the script it seems to fix itself.

I can PM you a screenshot if you would like.

I've had this happen, too, and have not yet been able to track this one down. If it happens every time with Bad Seam, that will help. Let me know of any other circumstance where this reliably happens.

[beergeek]

Hi Beergeek,

I am still getting stalls when some complication arise.

For instance, it's hanging on Bad Seam - Emergency Repairs. ER is the only comp up at this time and has 4 possible actions.

Minor repair, Fuse Damage, Access Damage, and Reinforce Stitching

When it hangs it looks like it is trying to click on an action that would be on the left of the first action that is actually there. It isn't missing be a little bit, it is missing by half of action block. In other words if the phantom action to the left were actually there it would be clicking in the middle of it.

If I start and stop the script it seems to fix itself.

I can PM you a screenshot if you would like.

A follow-up: I just had this happen to me again. Fortunately, I was running in full debug and think I may have found the culprit. Later, I'll make some tweaks, make sure the bot runs fine with the change, and post it so others can test this fix since it seems to occur very infrequently.

EDIT: The changes I made are a little too numerous to effectively describe here, so I'll try to push the next release out in the next day or two as time permits.

[officers]

Awesome, TY Beergeek.

[madzoko2]

hello beer

i keep getting error: line: 838, char: 4 :: Path not found

im a noob, thx

[madzoko2]

cancle that